anonymous908213 2 days ago

> Don’t pass around data of size 4046-4080 bytes or 8161-8176 bytes, by value (at least not on an AMD Ryzen 3900X).

What a fascinating CPU bug. I am quite curious as to how that came to pass.

  • srcmax 2 days ago

    That's called 4k aliasing. 4K aliasing occurs when you store one memory location, then load from another memory location which is 4KB offset from original.

    • gpderetta 7 hours ago

      Apparently these ~4k spikes are showing up only on AMD, and not on Intel, which is the one known to suffer from the 4k aliasing problem.

      I wonder if it has to do with a non-ideal implementation of virtual address resolution for the next page.

    • jmalicki 21 hours ago

      (and if it is not apparent to some readers, most modern x86-based systems use 64 byte cache line sizes, which is sort of analogous to disk block size - quite a few memory operations tend to happen in 64 byte chunks under the covers - the ones that don't are "special")

      • nabla9 19 hours ago

        To my knowledge all x86 based systems and ARM and Qualcomm designed chips all use 64 byte cache lines.

        Apple's M2 uses 128-byte cache line.

    • themafia 20 hours ago

      Would you expect different performance with 2M page sizes? Is this a TLB issue or just a fundamental hardware issue?

  • sgarland 2 days ago

    Me too, and I hope this article gets more traction.

  • jasonthorsness 2 days ago

    Apparently some sizes are cursed!

    It would be great to repeat the author’s tests on other CPU models

    • TuxSH 2 days ago

      I wonder what the page size is on his system (and what effective alignment his pointers have). If it's 4K, the sizes look really close to 0x1000 and 0x2000 - maybe crossing page boundaries?

      • astrange 21 hours ago

        It's because of cache addressing conflicts. If two addresses have the same cache key your cache suddenly doesn't work anymore. And many CPUs just use the low bits instead of hashing it.

        • Veserv 21 hours ago

          L1 caches are usually N-way associative, so that should only become a consistent problem if you access N distinct addresses with the same key (in this case the same offset (with likely 64-byte granularity) relative to a 4K boundary).

layer8 20 hours ago

> Passing structs up to size 256 is very cheap, and uses SIMD registers.

Presumably this means for all arguments combined? If for example you pass four pointers each pointing to a 256-byte struct, you probably don’t want to pass all four structs (or even just one or two of the four?) by value instead.

  • hyghjiyhu 4 hours ago

    If I understand correctly he is passing a single struct whose size he varies. This struct is being memcpy'd to stack (except for very small struct sizes that can be passed directly in registers) and so basically we are looking at a curve of memcpy performance by size.

  • adastra22 19 hours ago

    If you’re actually passing pointers to heap allocated objects, the pointer is the value.

pizlonator 19 hours ago

I would ignore this benchmark because it’s not going to predict anything for real world code.

In real world code, your caches and the CPU’s pipeline are influenced by some complex combination of what happens at the call site and what else the program is doing. So, a particular kind of call will perform better or worse than another kind of call depending on what else is happening.

The version of this benchmark that would have had predictive power is if you compared different kinds of call across a sufficiently diverse sampling of large programs that used those calls and also did other interesting things.

jklowden 2 days ago

There is no pass-by-value overhead. There are only implementation decisions.

Pass by value describes the semantics of a function call, not implementation. Passing a const reference in C++ is pass-by-value. If the user opts to pass "a copy" instead, nothing requires the compiler to actually copy the data. The compiler is required only to supply the actual parameter as if it was copied.

  • mattnewport 2 days ago

    This might be true in the abstract but it's not true of actual compilers dealing with real world calling conventions. Absent inlining or whole program optimization, calling conventions across translation units don't leave much room for flexibility.

    The semantics of pass by const reference are also not exactly the same as pass by value in C++. The compiler can't in general assume a const reference doesn't alias other arguments or global variables and so has to be more conservative with certain optimizations than with pass by value.

  • themafia 19 hours ago

    > Passing a const reference in C++ is pass-by-value.

    I can cast the const away. The implementation does not hide this detail. The semantics therefore must be understood by the programmer.

  • duped 2 days ago

    Unfortunately "the compiler is required to supply the actual parameter as if it was copied" is leaky with respect to the ABI and linker. In C and C++ you cannot fully abstract it.

  • Ericson2314 15 hours ago

    You are thinking "call by value". The author probably used "pass" not "call" specifically to avoid this.

    • kazinator 11 hours ago

      There is no difference. Call-by-alue is the older term, and I believe still preferred in CS acdemia.

      • gpderetta 7 hours ago

        I think that call-by-value/call-by-name/call-by-need[1] are more about strict vs lazy evaluation, as opposed to by-value/by-reference semantics.

        [1] there is also call-by-push-value, but i was never able to wrap my mind around it.

codedokode 2 days ago

I usually use ChatGPT for such microbenchmarks (of course I design it myself and use LLM only as dumb code generator, so I don't need to remember how to measure time with nanosecond precision. I still have to add workarounds to prevent compiler over-optimizing the code). It's amazing, that when you get curious (for example, what is the fastest way to find an int in a small sorted array: using linear, binary search or branchless full scan?) you can get the answer in a couple minutes instead of spending 20-30 minutes writing the code manually.

By the way, the fastest way was branchless linear scan up to 32-64 elements, as far as I remember.

  • themafia 19 hours ago

    > I still have to add workarounds to prevent compiler over-optimizing the code

    Yet remembering how to measure time with nanosecond precision is the burden?

    > By the way, the fastest way was branchless linear scan up to 32-64 elements, as far as I remember.

    The analysis presented in the article is far more interesting, qualified, and useful that what you've produced here.

  • lurquer 2 days ago

    In C++, I’ve noticed that ChatGPT is fixated on unordered_maps. No matter the situation, when I ask what container would be wise to use, it’s always inordered_maps. Even when you tell it the container will have at most a few hundred elements (a size that would allow you to iterate their a vector to find what your are looking for before the unordered_map even has its morning coffee) it pushes the map… with enough prodding, it will eventually concede that a vector pretty much beats everything for small .size()’s.

    • jcelerier 4 hours ago

      > (a size that would allow you to iterate their a vector to find what your are looking for before the unordered_map even has its morning coffee)

      I don't know about this, whenever I've benchmarked it on my use cases, unordered_map started to become faster than vector at well below 100 elements

    • bmandale 2 days ago

      I agree with chatgpt here

      • remexre 2 days ago

        isn't std::unordered_map famously slow, and you really want the hashmap from abseil, or boost, or folly, or [...]